Updated Turbulence PostFX - Visual Quality Enhancement
by smally · 07/30/2013 (10:04 am) · 28 comments
Well I don't have a video for this one, so if you feel so inclined set it up and run beneath some water.
Simple update for the turbulence postfx to make it look more visually appealing. I don't have time at the moment to do a video, as soon as I do get the time I will. This works with T3D Mit 3.0 but should work even for most older versions of T3D. I didn't test backdated engines outside of Mit 2.0, but there is nothing crazy going on in this shader. Just a replacement.
Instructions:
Download the zip, extract it and copy the files to your game folder. There are only 2 files to update, turbulence.cs and turbulenceP.hlsl
If needed I can post the contents here as well. Nothing major there.
Enjoy!
turbulence.zip
Simple update for the turbulence postfx to make it look more visually appealing. I don't have time at the moment to do a video, as soon as I do get the time I will. This works with T3D Mit 3.0 but should work even for most older versions of T3D. I didn't test backdated engines outside of Mit 2.0, but there is nothing crazy going on in this shader. Just a replacement.
Instructions:
Download the zip, extract it and copy the files to your game folder. There are only 2 files to update, turbulence.cs and turbulenceP.hlsl
If needed I can post the contents here as well. Nothing major there.
Enjoy!
turbulence.zip
About the author
Most people say that is it is the intellect which makes a great scientist. They are wrong: it is character. -- Albert Einstein
Recent Blogs
#2
07/30/2013 (12:14 pm)
lol, reduce the distortion variable? ;) and thanks Steve.. 
#3
bad to see that garagegames have inserted the shader under mit license and changed the copyrights without asking liman3d
07/31/2013 (7:56 am)
lol good to see somebody to work on my code from 2008 (shader pack vol 1)bad to see that garagegames have inserted the shader under mit license and changed the copyrights without asking liman3d
#4
07/31/2013 (12:33 pm)
@Ivan Mandzhukov: is this an infringement that we in the Steering Committee should investigate? If it is an issue then we can certainly see that it is removed.
#5
www.garagegames.com/community/blogs/view/22015
The turbulence shader that I know of, started off from that thread. I downloaded it, and modified it and put it back to the community from whence it came.
From that point, I didn't touch it until I just rewrote it completely about 2 weeks ago. It started life in that thread (as an idea to implement), and this isn't even THAT shader.
I believe it was community based efforts there from the start of that thread and I don't really believe anyone here is trying to change a license on anything that shouldn't be.
Edit: Actually, also check these links as well. I'm fairly certain this is where anyone got that original one from.
www.garagegames.com/community/forums/viewthread/99687
www.garagegames.com/community/forums/viewthread/93255
www.garagegames.com/community/forums/viewthread/119707
07/31/2013 (1:24 pm)
Ummm what? That would be news to me Ivan. Honestly. Look at this threadwww.garagegames.com/community/blogs/view/22015
The turbulence shader that I know of, started off from that thread. I downloaded it, and modified it and put it back to the community from whence it came.
From that point, I didn't touch it until I just rewrote it completely about 2 weeks ago. It started life in that thread (as an idea to implement), and this isn't even THAT shader.
I believe it was community based efforts there from the start of that thread and I don't really believe anyone here is trying to change a license on anything that shouldn't be.
Edit: Actually, also check these links as well. I'm fairly certain this is where anyone got that original one from.
www.garagegames.com/community/forums/viewthread/99687
www.garagegames.com/community/forums/viewthread/93255
www.garagegames.com/community/forums/viewthread/119707
#6
I just wanted to step in and mention that GarageGames did not take your code, rip out the copyright header, and put it in Torque 3D. GarageGames does not make any decisions any more as to what goes into the T3D repo.
In this case the shader in question came from a Pull Request from a community member: github.com/GarageGames/Torque3D/pull/374. It is up to the T3D Steering Committee to determine what goes into the T3D repository and we will act accordingly if there has been a copyright infringement. The first step is in letting us, the Committee, know about the issue (which we'll assume has been kicked off from this thread).
Ivan, if you could please work with Mike Hall we would like to sort this out. Thanks!
- Dave
07/31/2013 (1:34 pm)
@Ivan:I just wanted to step in and mention that GarageGames did not take your code, rip out the copyright header, and put it in Torque 3D. GarageGames does not make any decisions any more as to what goes into the T3D repo.
In this case the shader in question came from a Pull Request from a community member: github.com/GarageGames/Torque3D/pull/374. It is up to the T3D Steering Committee to determine what goes into the T3D repository and we will act accordingly if there has been a copyright infringement. The first step is in letting us, the Committee, know about the issue (which we'll assume has been kicked off from this thread).
Ivan, if you could please work with Mike Hall we would like to sort this out. Thanks!
- Dave
#7
07/31/2013 (1:37 pm)
Wow seriously un freakin believable! Well let me know if you need anything from me, I'm kinda blown away by all this. 
#8
@Smally; just tried it last night. I wanted to post a video today but I guess it's better to wait with that. Anyway, many thanks for the work you have put into this!
07/31/2013 (6:56 pm)
Thanks for pointing this out @Ivan. This issue must certainly be cleared before any commercial projects are being released to the public.@Smally; just tried it last night. I wanted to post a video today but I guess it's better to wait with that. Anyway, many thanks for the work you have put into this!
#9
If the code was completely rewritten why are we even having this conversation? What is the pedigree of this code?
08/01/2013 (8:20 am)
Is there a resolution on this? I don't want code that isn't supposed to be in the repo. Now I need to go through and clean it out if we cannot definitely verify the pedigree of this code. If the code was completely rewritten why are we even having this conversation? What is the pedigree of this code?
#10
08/01/2013 (9:04 am)
From the committee's investigation so far there is enough similarity within the code to be concerned, unfortunately neither of the parties involved have replied yet in order to help us resolve things.
#11
@Demo - I removed the link until I get clearance on this so it wouldn't further compound any issue. If the committee needs the link I can send via email to the unmodified package.. or just repost it at the top.
08/01/2013 (9:13 am)
@Michael: your talking about the original shader correct? The one I posted is not the same thing. @Demo - I removed the link until I get clearance on this so it wouldn't further compound any issue. If the committee needs the link I can send via email to the unmodified package.. or just repost it at the top.
#12
08/01/2013 (9:20 am)
@smally: correct. If you wouldn't mind would you send me a copy of yours for comparison as well?
#13
Thanks for the update. I appreciate the committee jumping right on this and looking for a resolution.
@smally,
I figured as much.
08/01/2013 (9:21 am)
@Michael,Thanks for the update. I appreciate the committee jumping right on this and looking for a resolution.
@smally,
I figured as much.
#14
Ivan is currently on vacation. Please let me clear this issue. We at Liman3D are cool guys, I personally have nothing against that a certain shader that came with any of our shader packs to be inserted into T3D MIT as soon as there is a huge interest about it.
I have just talked to Ivan about this. He actually meant that it would be good if someone could just first ask us before posting it under MIT license and giving credits to Ivan Mandzhukov, Liman3D.
Therefore please leave the shader available in T3D MIT if you wish so, but please give credits to "Ivan Mandzhukov, Liman3D"
08/01/2013 (11:53 am)
Hello everyone,Ivan is currently on vacation. Please let me clear this issue. We at Liman3D are cool guys, I personally have nothing against that a certain shader that came with any of our shader packs to be inserted into T3D MIT as soon as there is a huge interest about it.
I have just talked to Ivan about this. He actually meant that it would be good if someone could just first ask us before posting it under MIT license and giving credits to Ivan Mandzhukov, Liman3D.
Therefore please leave the shader available in T3D MIT if you wish so, but please give credits to "Ivan Mandzhukov, Liman3D"
#15
Thank you Lyubomir, for taking the time on this.
08/01/2013 (12:46 pm)
It's more about making sure that any code being merged into the codebase is clear of these kinds of issues. I can't blame anyone for that. I personally prefer taking appropriate action, over not. Ivan could have been a little more clear though ;) So things don't get blown out of proportion.Thank you Lyubomir, for taking the time on this.
#16
Anyway I think dropping the shader packs from our site was wrong, I will make sure to bring them up again soon.
08/01/2013 (2:21 pm)
No problem, smally. I'm glad we sorted that out.Anyway I think dropping the shader packs from our site was wrong, I will make sure to bring them up again soon.
#17
08/01/2013 (3:06 pm)
@Lyubomir, you have at least 1 sale waiting on them being available again :-)
#18
08/01/2013 (11:24 pm)
cool :)
#20
I have been out in the woods doing 'army' training for the last two weeks so this is the first time I have had a chance to reply.
@Ivan Sorry brother. I did not realize that this code www.garagegames.com/community/forums/viewthread/93255/4#comments was associated with your product. I based the turbulence segment completely around what I thought was 'public' code. I don't own your packs and therefore could not verify any similarities. I went off the assumption that forum code was 'fair use'. I will try and do a better job of making sure code is properly public. Sorry for that, it was not intentional in any way. Additionally, I asked the community for fixes since the turbulence in the original code was a bit 'messed up' I probably should have dug deeper into that code as well.
I am still learning and I am happy to see that things are getting worked out but, I do take full responsibility for not checking that particular code snip more succinctly. Additionally, if you download the original file that was linked with the video, you will note in the code that I specifically stated it was based on Manoel Neto's work. Either way, I will try to a better job in the future.
Ron
08/09/2013 (5:34 pm)
ALL,I have been out in the woods doing 'army' training for the last two weeks so this is the first time I have had a chance to reply.
@Ivan Sorry brother. I did not realize that this code www.garagegames.com/community/forums/viewthread/93255/4#comments was associated with your product. I based the turbulence segment completely around what I thought was 'public' code. I don't own your packs and therefore could not verify any similarities. I went off the assumption that forum code was 'fair use'. I will try and do a better job of making sure code is properly public. Sorry for that, it was not intentional in any way. Additionally, I asked the community for fixes since the turbulence in the original code was a bit 'messed up' I probably should have dug deeper into that code as well.
I am still learning and I am happy to see that things are getting worked out but, I do take full responsibility for not checking that particular code snip more succinctly. Additionally, if you download the original file that was linked with the video, you will note in the code that I specifically stated it was based on Manoel Neto's work. Either way, I will try to a better job in the future.
Ron
Associate Steve Acaster
[YorkshireRifles.com]
Also ...
... can somebody pass the sick bucket? ;)