Players in multi-player game can command eachothers units

#1 Good catch Joshua! I've checked it and found the problem. I made it only on the stock kit though, so you will have to follow my reasoning to solve this on the World Domination Mod too.

So, as you well said, in inputHandler.cs all seems to be fine, all over the place the inputs seem to be called looking at PlayGui.selectionIncludesTeam first. That of course lead us to the root, is that flag been correctly setted?

The problem was an incorrect assumption in selection.cs, more precisely within GuiRTSTSCtrl::selectObject() function. This sets the selectionIncludesTeam flag to true, if the object is owned by us, assuming that if not, somewhere in the code the flag was setted previously to false. Lucky for us, is a pretty easy situation to fix; in the function (around line 30) add the lines in bold:

function GuiRTSTSCtrl::selectObject(%this,%obj)
{
   if(!%this.selectionLocked)
   {
      %this.addToSelection(%obj);
      commandToServer('AddToSelection', %obj.getGhostID());
      CommandMenu.visible = "1";
      %this.refreshSelectionDisplay();
      SelectionDisplay.visible = "1";
      if(%obj.getTeam() == ServerConnection.getTeam())
         %this.selectionIncludesTeam = true;
      [b]else[/b]                                                                // add this
         [b]%this.selectionIncludesTeam = false;[/b]        // two lines
   }
}

Also, I found that you can order foreign units to STOP and to HOLD. This, however has another source problem, which is that those commands are sent to the server without any kind of checking. So lets add some: in the file client\ui\playGui.gui around line 430, add th lines in bold:

function CommandMenu::onStopClick()
{
	[b]if (PlayGui.selectionIncludesTeam)[/b]     // add this line
	   commandToServer('IssueStop');
}

function CommandMenu::onHoldClick()
{
   PlayGui.setCommandState("Hold");
   [b]//[/b]commandToServer('IssueStop');          // comment this line
   [b]CommandMenu::onStopClick();[/b]              // add this line
}

Well thats all. If you find troubles to solve the situation on World Domination, let us know.

#2 Thanks for your help Novak. those fixes seem to have worked and i got some other similiar bugs fixed also.