Cannot Save Settings

#1 OK, that's squared away ... next ...

#2 Any luck/workaround with this one, Jeremy? We're trying to do the same thing...

#3 Sure, here it is:

Add/change these in your "/game/main.cs"

function loadPath( %path )
   {
   
      setMyGamesModPaths( getMyGamesModPaths() @ ";" @ %path );
      exec(%path @ "/main.cs");

   }


   function setMyGamesModPaths()
   {
      // Another way to get the mod path by searching it
      %modPath = findfirstfile("*/game/main.cs");
      if(isFile(%modPath))
         $myModPath = filePath(%modPath) @ "/";
      else
      {
	   %modPath = findFirstFile("*/game/main.cs.dso");
	   $myModPath= filePath(%modPath) @ "/";
      }
   }

   function getMyGamesModPaths()
   {
      return $myModPath;
   }

Then ...

Replace these lines in the "/common/main.cs" script file

//_loadGameConfigurationData( expandFileName("./commonConfig.xml") ); //Original
   _loadGameConfigurationData( getMyGamesModPaths() @ "commonConfig.xml" );

   //_saveGameConfigurationData( expandFileName( "./commonConfig.xml") ); //Original
   _saveGameConfigurationData( getMyGamesModPaths() @ "commonConfig.xml" );

#4 Jeremy, one point of clarification: the first block of code goes in the game/main.cs, not in the common/main.cs, right?

#5 Yes, that's what I did. You could also save the settings in the common folder if you wanted too.

#6 Hi,

I've tried this unsuccessfully. Is there a trick?

I just have copied and pasted both code blocks. Any renaming convention with getMyGamesModPath or some specific name path with my game name such $myModPath= filePath(%modPath) @ "/";?

#7 Here is the function I use in my game.cs file:

function expandFilenameFix(%thePath) {
	%prePath = findfirstfile("*/game/main.cs");
	%thePath = stripChars(%thePath,"~");
	%thePath = filePath(%prePath) @ %thePath;
}

I always use expandFilename before using the filesystem, so it was easy for me to do a find and replace across my scripts to substitute this temporary function. When the fixed update is out, I will just find/replace back.

Greg

#8 Thanks! I spent around 2 hours trying to figure out why my XML file was not getting saved. beginWrite was failing. I was able to read it just fine. Once I finally realized the GG code for _saveGameConfigurationData was not even saving my the commonConfig.xml file, I knew something was up. Suddenly I recalled having heard about a File I/O issue so I did a search.

If this site had stickies, this should be a sticky. Thanks agian!

#9 Jeremy,

I am confused by one thing. You suggest a change to common/main.cs that references a function in game/main.cs. When I look at the console log I see that common/main.cs is loaded before game/main.cs. Are the scripts not being executed at that point? Otherwise, how can a function in common/main.cs reference a function that has not yet been loaded?

#10 In your console you see the scripts being compiled but the function itself isn't called at that point. Once the game actually compiles all the scripts then it begins true function level execution.

#11 Thank you Jeremy for the explanation.

#12 Jeremy,

There is a typo in your code for "/common/main.cs".

Your code has getMyGamesModPath() but the function is named getMyGamesModPaths()

#13 Good call! My game actually uses different names so I typed those seperately ;0

#14 Tetraweb, Jeremy,

I have tried both your suggestions without success. commonConfig.xml is not updated and an error is thrown.

#15 CommonConfig inside the game directory and not the common directory? What is the error? I honestly got this working a while ago. I might have had to do a few things different from this thread but now it's in the blurry past.

#16 I'm having a similar issue but it's a 2 part problem.

Part 1: To fix the file search issue described above, look at the "onExit()" function in the common/main.cs file. I just replace this line:

_saveGameConfigurationData( expandFileName("./commonConfig.xml") );

with this line:

_saveGameConfigurationData (findFirstFile("*/commonConfig.xml"));

Part 2: My global screen resolution variable "$Game::Resolution" is not being updated at the time I'm saving the common configs. I added this line in the beginning of the "_saveGameConfigurationData()" function in the "common\gameScripts\properties.cs" file:

echo("resolution ["@ $Game::Resolution @"]");

Sure enough, this value was not updated via the GUI interface.
I gotta run off to some meetings now, but I'll update the thread when I find out more.

#17 I added two new variables for the resolution and I also had to make a fix to save the full screen flag. That was something I neglected to mention here. However, those had nothing to do with the actual file being written. They were just oversights elsewhere in the code.

#18 Jeremy,

When I shutdown my game, the following is in the console.log:

XML::beginWrite - Failed to write to filecommon/commonConfig.xml.
saveGameConfigurationData - Failed to write to file: common/commonConfig.xml

The question I have is, isn't the problem with writing to the file and not a problem with finding the file to write to? Even without making any changes to 1.5.1, file is being found and read in without any modifications needed. I don't see how simply changing the path/filename will make any difference.

At this point I am going to sit tight and wait for the next patch to TGB. This must be a priority bug for the developers to fix. I can't see it not being fixed.

Thanks for you help.

#19 Jeremy,

Something you wrote got me thinking: "CommonConfig inside the game directory and not the common directory?"

I don't have a commonConfig.xml file in my games directory, only in my common directory. When I use Torsion and look at what is being read in [common/gamescripts/properties(39)], it is loading common/commonConfig.xml.

So, if your code and Tetraweb's code is writing to the game directory, then when does it load games/commonConfig.xml? Or are you modifying properties.cs as well, so it loads from the game directory?

#20 Yeah mine is loading from the game directory because that's what I wanted to do. The code above looks for the file in the game directory to get the path.