Infinite Jumps?

#1 One way to do it is to have a Global Variable (something like $Intheair).

The basic logic here is that when your character collides with the ground, set it to false

//This obviously means that you have a ground object named "The_Ground"

Goblin.onCollision(%this, %object, %collisionDetails)
{
//%this will be the Goblin
//%object will be the object we've collided with
//%collisionDetails will contain several details, impulses, vectors and the like

if(%object.getName() $= "The_Ground")
{
$IntheAir = false;
}

}

then, in your jump function (GoblinUp)

if(!$IntheAir)
{
//We are on the ground
Goblin.SetLinearVelocityY(7);
$IntheAir = true;
}

!Free Tip!

When you want to see if a specific variable is equal to a string, use $= as in

if(mystringvariable $= "Some Text")

using == to compare strings won't work, use it instead to compare values

if(myvariable == 5)

#2 I put the code in but I'm getting a parse error from my player.cs:

C:/Users/John/Documents/Torque Projects/FirstGame/modules/myModule/scripts/player.cs Line: 33 - parse error
>>> Advanced script error report.  Line 33.
>>> Some error context, with ## on sides of error halt:
    %player.createPolygonBoxCollisionShape();



    %player.setCollisionCallback( true );



    %player.setCollisionLayers(5);    

    %player.setDefaultFriction(0);

    

    

    myScene.add( %player );   

   

  

  }

  

Goblin.onCollision(%this, %object, %collisionDetails)  

{

##/##/%this will be the Goblin  

//%object will be the object we've collided with  

//%collisionDetails will contain several details, impulses, vectors and the like     

   

if(%object.getName() $= "floor")  

{  

$IntheAir = false;  

}  

  

}

#3 Try:

function Goblin::onCollision(%this, %object, %collisionDetails)

When defining a function, put function in front of it and use :: to separate the class name from the method name. When using a function, just use the object and a dot, then the method name ( %this.onCollision()). In your case it is a callback and you will probably never call this yourself....

Simon, I'm disappointed. ;p

#4 I changed it and now the .exe does run, but it just behaves as before, here is the player.cs:

function createPlayer()
{
    %player = new Sprite(Goblin);
    $Goblin = %player;

    %player.setBodyType( dynamic );
       
  
    %player.Position = "0 0";

      
    %player.Size = "7 7";
    
  
    %player.SceneLayer = 1;
    
    %player.Image = "myModule:goblin";

    %player.createPolygonBoxCollisionShape();

    %player.setCollisionCallback( true );

    %player.setCollisionLayers(5);    
    %player.setDefaultFriction(0);
    
    
    myScene.add( %player );   
   
  
  }
  
function Goblin::onCollision(%this, %object, %collisionDetails)  
{
//%this will be the Goblin  
//%object will be the object we've collided with  
//%collisionDetails will contain several details, impulses, vectors and the like     
if(%object.getName() $= "floor")  
{  
$IntheAir = false;  
}  
  
}

It's late, am I missing something obvious?

#5

Quote:I changed it and now the .exe does run, but it just behaves as before,

Do you mean it runs but your character doesn't jump?

I don't see the GoblinJump function, I assume it sets $IntheAir to true?

In any case, first check if the 'onCollision' is called when it's supposed to by adding an echo statement like so

function Goblin::onCollision(%this, %object, %collisionDetails)    
{
echo("Testing Testing Testing"); 
}

The results will show up in the console (CTRL+~) when the function is called.

#6 Did you name your ground "floor"?

Did you add the check for $IntheAir == false (or !$IntheAir) in your jump function, and then set it to true after jumping?

#7 I think I've got %this.OnCollision(); in the wrong place as the echo "Testing" isn't appearing in the console, where should I be putting %this.OnCollision();?

#8 You don't explicitly call the Goblin::onCollision() yourself, it just gets called whenever collisions are occurring.

Bear in mind that when first creating your object, you need to set it to trigger this function

Goblin.setCollisionCallback(true);

If you don't do this, the physical collisions will still happen (objects will bounce off each other) but the function, even if it exists, will never be called.

#9 Hmm I have %player.setCollisionCallback(true); already in my player.cs... Maybe my "floor" is incorrect?

Here's the script for the floor (levelone.cs):

function createFloor()
{
    %floor = new Sprite(floor);
    %floor.setBodyType(static);
    %floor.Position = "0 -35";
    %floor.Size = "100 10";
    %floor.Image = "myModule:floor";
    %floor.createPolygonBoxCollisionShape();
//    %floor.createEdgeCollisionShape( -50, -37.5, -50, 37.5 );
    %floor.setCollisionCallback( true );
    %floor.SceneLayer = 5;
    %floor.setDefaultRestitution(0.1);
    myScene.add(%floor);

#10 Two things that might help,

1- %floor.createPolygonBoxCollisionShape();

You should specify a width and height for your collision shape.

You can also call SandboxScene.setDebugOn("collision"); to show the collision shape outlines of your scene. (If you're not using the Sandbox, your Scene might have a different name)

2 - Setting Collision Callbacks for the floor will work but might be overkill, usually you only need the callback on one of the main objects.

#11 It worked! Thanks so much for your help guys.

#12 We'd love to see screenshots or videos of that Goblin some day! :)