Please fix quote and slash issues in posts
by Demolishun · in Site Feedback · 08/05/2012 (2:40 am) · 23 replies
I just submitted a resource:
www.garagegames.com/community/resources/view/21813
When I go to edit this resource it replace the quotes with &quote; text. If you save at this point it hoses the resulting resource/post.
If I use a slash like for this:
The first example I actually had to use 2 slashes to get it work properly. The second I used one and it produces garbage.
www.garagegames.com/community/resources/view/21813
When I go to edit this resource it replace the quotes with &quote; text. If you save at this point it hoses the resulting resource/post.
If I use a slash like for this:
'\0'I have to put 2 slashes to prevent garbage as in this case:
'[[62877ff7793c9]]'
The first example I actually had to use 2 slashes to get it work properly. The second I used one and it produces garbage.
About the author
I love programming, I love programming things that go click, whirr, boom. For organized T3D Links visit: http://demolishun.com/?page_id=67
#2
I have used lots of CMS frameworks and I have never seen anything like that before. Is it some custom PHP or something? It is easy to reproduce so we have that going for us. That should make it easier to isolate.
The one that worries me is the slash. It seems to trigger an escape sequence. This might be used to do something nefarious like a buffer overflow of the webserver.
08/05/2012 (11:57 am)
I was so frustrated last night as I spent more time fixing my post to get it to look right than I did writing the code. It tends to deincentivize sharing code.I have used lots of CMS frameworks and I have never seen anything like that before. Is it some custom PHP or something? It is easy to reproduce so we have that going for us. That should make it easier to isolate.
The one that worries me is the slash. It seems to trigger an escape sequence. This might be used to do something nefarious like a buffer overflow of the webserver.
#3
But yeah, you're right about it causing us to lose incentive to share code. I've got several Resource I've simply never bothered with simply because of the amount of work it would take to correct if I ever edited them.
08/05/2012 (12:02 pm)
The only official comment I've seen regarding either one is that it's a known issue and has been brought to the attention of the webteam... but apparently there's so much custom code to their webpage that's it hard to fix.But yeah, you're right about it causing us to lose incentive to share code. I've got several Resource I've simply never bothered with simply because of the amount of work it would take to correct if I ever edited them.
#4
www.garagegames.com/community/resources/view/21864
The slash issue I can live with as it is not an easy fix to isolate. I don't really do escape characters in code very often.
09/01/2012 (7:37 pm)
Okay, I finally broke down and fixed this partially:www.garagegames.com/community/resources/view/21864
The slash issue I can live with as it is not an easy fix to isolate. I don't really do escape characters in code very often.
#5
Is Zend really so limited you have to code input/output yourselves?
09/03/2012 (8:58 am)
GG: Mail me if you need somebody to look at the frickin' UTF/I18N issues. It's alright to admit if you're struggling. This shouldn't be rocket surgery, though. My own PHP crap supports even Irish names without freaking out! (And I need it, with the co-admin being Irish.)Is Zend really so limited you have to code input/output yourselves?
#6
09/05/2012 (10:32 am)
This is a problem that stems from many iterations of the site. We haven't updated any posting code in a long time. However, there has been some admin panel data entry code that has been updated. Much of it uses the old, old, old GG site codebase. We're looking back through the repo commits to see where this change could have been made in the last several months.
#7
Yes, it is a hack, but since this site is going to be updated it saves you time and saves everyone posting a LOT of frustration.
09/06/2012 (11:56 am)
I don't know how your system is structured, but the Javascript code I wrote could solve the & issue by being applied after everything else has. Most sites have a Javascript function that runs after everything is loaded to clean up, fix, rearrange, etc. The function could go in there for GG. It only looks at the content box for forum submissions.Yes, it is a hack, but since this site is going to be updated it saves you time and saves everyone posting a LOT of frustration.
#8
09/06/2012 (2:47 pm)
It should be fixed now.
#9
& also ' ; : do these things work?#~
[edit]
My Face When:

Dave MB for Prez! Yeah I know he's only the messenger but hey :P
[double edit]
And I've edited again! And it still works!
09/06/2012 (3:39 pm)
"Are you """sure""" about that"?& also ' ; : do these things work?#~
[edit]
HUZZAR
My Face When:

Dave MB for Prez! Yeah I know he's only the messenger but hey :P
[double edit]
And I've edited again! And it still works!
#10
09/06/2012 (3:41 pm)
They should.
#11
09/06/2012 (3:49 pm)
Okay, backslash is still bust but if it's just that, we can live with it.
#12
09/06/2012 (3:52 pm)
Upon editing a resource all my quotes(") are being replaced with "e; and & with & in the text area box. Definitely not fixed.
#13
09/06/2012 (3:53 pm)
Do you get it with blog posts as well so I can have the webteam and QA go through these areas?
#14
09/06/2012 (4:00 pm)
Resources are still bust and so are blogs. Just forums fixed. My ecstatically happy little girl gif was too soon ...
#15
Now the only part that needs to be fixed is the backward slash disappearing issue and then we'll have a completely working forum. Yay! :D
09/06/2012 (5:07 pm)
Alright, I have tested and confirmed that the &(ampersand) and "(quote) problem has been fixed on editing forum posts. But the problems still persist with blogs and resources, because presumably they're apart of different PHP code from regular forums that they haven't been updated yet.Now the only part that needs to be fixed is the backward slash disappearing issue and then we'll have a completely working forum. Yay! :D
#16
09/06/2012 (5:55 pm)
Plus PMs and hiding our e-mail addresses. And THEN it will be complete, apart from international issues, special symbols they didn't think of etc. But THEN it will be completely fine! Maybe.
#17
09/07/2012 (9:21 am)
Blog and Resource body is fixed. I have tested editing the bodies of these, but the preview area is still a problem (the blurb you see when on the blog page).
#18
09/07/2012 (9:27 am)
Or at least I couldn't get the body to break when I tested it.
#19
09/07/2012 (9:40 am)
To do PM's right, we would want to move to a different forum system. As for e-mails, I'm not seeing them when I look at your profile unless I'm logged in as an admin.
#20
09/07/2012 (11:09 am)
That's because I switched it off ;)
Associate Michael Hall
Distracted...
It's way past time that either one was fixed.