Game Development Community

resolved - simset.h public-private back to front?

by Steve Acaster · in Torque 3D Professional · 08/05/2010 (1:27 am) · 2 replies

As I can't really code, thought I'd better ask ...

but the Public and Private declarations for friend classes in source/console/simset.h "class SimGroup: public SimSet" appear to be reversed in 1.1beta2 from all previous versions ...

1.1beta1 and prior
class SimGroup: public SimSet
{
private:
   friend class SimManager;
   friend class SimObject;

   typedef SimSet Parent;
   SimNameDictionary nameDictionary;

   void removeObjectNoLock(SimObject*);

public:
   ~SimGroup();
//...etc etc

and now in 1.1 Beta 2
class SimGroup: public SimSet
{
   public:
   
      typedef SimSet Parent;

      friend class SimManager;
      friend class SimObject;

   private:

      SimNameDictionary mNameDictionary;

      void _addObject( SimObject* object, bool forcePushBack = false );
      void _removeObjectNoLock( SimObject* );

   public:

      ~SimGroup();
//... etc etc

Just checking ...

edit:
Not an issue - resolved

#1
08/05/2010 (2:21 am)
Aside from the Parent typedef which is now public (it should be; allows templates to operate on it), this change is more cosmetic. The friends aren't affected by this and the rest is private as before.
#2
08/05/2010 (2:55 am)
Yeah, I was thinking this was just me being paranoid ... just going through all of the bugfixes I had in code to check what's in (which is a lot!) and what isn't when I noticed this difference.

Moved to resolved