vehicle issues - ctrl x not working and wheel animation stopping - RESOLVED

#1 Wheel animations seem to stop for the control object vehicle in a number of situations, including simply crashing into another vehicle while in 3rd person view. Exiting the vehicle and re-entering seems to correct it. Seems totally unrelated to anything going on in the physics, as the vehicle continues to move normally.

#2 Logged: TQA-570

#3 The key bind "ctrl x" works for me.

#4 Greetings!

Wow, this was a tough one to hunt down. It had nothing to do with vehicles in the end, and would affect any object that the Player class could control that relies on advanceTime() for client-side effects.

What would happen is when you switch the GameConnection's object that is being controlled from something like the camera, back to the Player (happens in GameConntrion::readPacket()), the Player's readPacketData() gets called to sync things back up with the client. Within Player::readPacketData() the object being controlled by the Player is again set, which in the case of this thread is a WheeledVehicle.

When Player::setControlObject() is called, it clears out the old control object and adds the new one. Behind the scenes this calls SceneObject::setProcessTick() on the controlled object and fiddles with how the object's processTick(), interpolateTick() and advanceTime() are called.

Unfortunately, when you clear the control object and then set it back to the same object right away, advanceTime() for the control object (WheeledVehicle here) gets pulled out of the process link list and ends up not being called any more. IIRC the right combination for this to happen is the control object also needs to be mounted by the Player. For WheeledVehicle, this means no wheel or shock animation.

When the Player dismounts, the Player's control object is cleared and with the mount also gone, the WheeledVehicle is correctly added back to the process list.

Whew! Now for the crazy fix. At the top of Player::setControlObject() add the following:

if (mControlObject == obj)
      return;

And that's it! This fix is now in place for the next release of T3D.

- Dave

#5 @David, was it a THREED-1320?
From this thread.

#6 Hey Bank.

Well...yes, it is. Looks like the ticket was pointing to this thread instead of the correct one. Too bad. I could have just used your fix and saved some time. :P

Thanks!

- Dave

#7 hehe, yeah, i know, that "easy" fix took some time on debugging for me too, so I know what you mean :)

#8 Fixed in 1.1 Final and Preview.

#9 Yay....