onMouseDragged and onRightMouseDragged not working in T3D?

#1 I'm not sure I understand all the changes you made. We would need more information from you in order to determine what it is you are looking for information wise.
Example:
Did you make the appropriate changes to the Header file?

Did you make a script function and What does your script function look like?

What did you base your function off of? Did you use a Drag like control like a slider bar?

#2 I'm having this same problem here, since i'm a noob, i thought that i was using in a wrong way the playgui::onRightMouseDragged , i'm trying to use this to be able to rotate the camera in the game mode, like the world editor mode that you drag the right mouse button, i think travis is trying to do the same.

#3 Okay, I've made some corrections and narrowed down the problem a bit.

First off, to answer your questions Jesse, yes I updated the header files appropriately (otherwise it would never compile!). In fact, it compiles perfectly - no errors or warnings.

I've gone ahead and attempted to implement the whole thing on the engine side instead of in script. There are several changes I've made to the code, and I'll list what I have here.

T3D\gameTSCtrl.cpp - In the section where near void GameTSCtrl::onMouseDown(const GuiEvent &evt), I added the following function.

void GameTSCtrl::onRightMouseDragged(const GuiEvent &evt)
{
   // We don't want to use the parent function here because it's empty.
   //Parent::onRightMouseDragged(evt);
   GuiCanvas *canvas = getRoot();
   if( !canvas )
         return;
   PlatformWindow *window = static_cast<GuiCanvas*>(getRoot())->getPlatformWindow();
      if( !window )
         return;

   if(mRightMouseDown)
   {
	   // Disable the mouse cursor. This will set us into mouselook mode.
	   window->setMouseLocked(true);
	   canvas->setCursorON( false );
   }
   else
   {
	   // Re-enable the mouse cursor. Is this check needed here?
	   window->setMouseLocked(false);
	   canvas->setCursorON( true );
   }

   // See if there is a script function. If so, execute it.
   if( isMethod( "onRightMouseDragged" ) )
      makeScriptCall( "onRightMouseDragged", evt );
}

This code works as it should. (I know, its a bit messy and needs cleaning up, but it works.)

The problematic portion is

void GameTSCtrl::onRightMouseUp(const GuiEvent &evt)
{
   // We don't want to use the parent function here because it's empty.
   //Parent::onRightMouseUp(evt);

   mRightMouseDown = false;
   mouseUnlock();
   Con::errorf("onRightMouseUp");

   //if( isMethod( "onRightMouseUp" ) )
      //makeScriptCall( "onRightMouseUp", evt );
}

I've commented out the reference to the Parent's function, because after tracing it I found that there's nothing in it. So, I decided to build in my functionality here.

This function works until I right click and drag the mouse. From that point on, this function is not called whenever I right click, and wont come out of mouse look mode.

So, my question is - how do I go about getting this function to work while in mouse look mode? I need to be able to detect when the right button is released so I can unhide the cursor.

Thanks,

-Travis

#4 If I was you and I wanted to implement some simple functionality such as this. I would just script it in Torque Script. I mean to be honest
I would just put 2 functions in. It really seems like your thinking a little to hard about this.

assuming that the PlayGui is your GameTSCtrl name
function playGui::onRightMouseDown()
{
   schedule(0, 0, "hideCursor");
}

function playGui::onRightMouseUp()
{
   schedule(0, 0, "showCursor");
}

If I have my cursor on the playgui already then when I right click and hold it will hide it and I will regain movement by mouse and when I let go.

#5 jessel: i tried this code before, and tried this one exactly the way you wrote, but this didn't work, i think the problem is when we are in the nocursor mode, the system don't detect the onrightmouseup() in the playgui, and i don't know if there is another GameTSCtrl to manipulate

#6 Right, this was something I tried as well. It doesnt work for the reason that Chico says. However, as opposed to another GameTSCtrl, I think what is happening is that the gameTSCtrl loses control of the input when the cursor is turned off, and the control is instead given to the actionMap. I haven't yet confirmed this, though.

Any insight from the GG team would be much appreciated as well. :)

Thanks guys,

-Travis

#7 Edit ok It apears I forgot that when you cursor goes away that you can't call an onRightMouseUp call at that point since the cursor isn't available.

So, a simpler way perhaps would be to just do this

//hide the cursor if its is active
function playGui::onRightMouseDown()   
{   
   schedule(0, 0, "hideCursor");   
}   
//show the cursor if it is inactive
//add this to your control binds
moveMap.bind( mouse, button2, showCursor );

This way if you click the middle mouse it goes to non-cursor mode and if you click it again it goes to cursor mode

#8 thanks for this code JesseL, but i think this extra bind, won't work very well for a final user, it's not so intuitive, I'm trying to find something that Matt Huston posted in my other topic http://www.garagegames.com/community/forums/viewthread/103493
about the EditTSCtrl source code, since the world editor has a similar control.

#9 Sigh so I sat through searching for a way to make this work like it did in TGEA but. No luck. Already spent like 5 hours on this so I'm done. Good Luck!

#10 Couple threads about this bouncing around. In http://www.garagegames.com/community/forums/viewthread/104041 it is noted that the reason mouse input stops processing is because in GuiCanvas::processInputEvent it checks if mCursorEnabled prior to calling processMouseEvent.

If you change this condition it'll get you past the first hurdle, possibly by adding a new condition in that or for a mouselook drag.

#11 I'm beginning to wonder if I should attempt to control the actual rotation of the camera in the onRightMouseDragged() function itself instead of relying on hiding the mouse cursor and such. Take, for example, the way the GuiObjectView works.

My only problem with that is finding a way to access the camera's position/rotation from the GameTSCtrl. Any thoughts on this?

#12 So I tried implementing a similar solution to what Jesse suggested...hiding the cursor in PlayGui's onRightMouseDown, and showing it in the ActionMap's button1 up callback - the problem is the callback isn't called because it ignores a "break" even (mouse up, key up, etc) if it doesn't have a matching "make" event (key down, mouse button down, etc) - looks like a small code change could pretty easily fix this, but I don't think it's doable script-only.

#13 Hm, interesting. I wonder if it pointed to an empty function for the make event, if that would work? I'm not at a computer to check it right now, so I'll have to try later. If anyone else has any luck, please let me know :)

#14 What I did to get it to work (and cause another interesting bug):

In PlayGui.cs:

function PlayGui::onRightMouseDown(%this, %doubleClick)
{
   $rightMouseDown = 1;
   GlobalActionMap.bind( mouse, xaxis, yaw );
   GlobalActionMap.bind( mouse, yaxis, pitch );
}

function PlayGui::onRightMouseUp(%this, %doubleClick)
{
   $rightMouseDown = 0;	
   GlobalActionMap.unbind( mouse, xaxis);
   GlobalActionMap.unbind( mouse, yaxis);
}

In default.bind.cs:

$rightMouseDown = 0; //At the top of the file

function yaw(%val)
{
   if($rightMouseDown)
   {
      %yawAdj = getMouseAdjustAmount(%val);
      if(ServerConnection.isControlObjectRotDampedCamera())
      {
         // Clamp and scale
         %yawAdj = mClamp(%yawAdj, -m2Pi()+0.01, m2Pi()-0.01);
         %yawAdj *= 0.5;
      }
      $mvYaw += %yawAdj;
   }
}

function pitch(%val)
{
   if($rightMouseDown)
   {
      %pitchAdj = getMouseAdjustAmount(%val);
      if(ServerConnection.isControlObjectRotDampedCamera())
      {
         // Clamp and scale
         %pitchAdj = mClamp(%pitchAdj, -m2Pi()+0.01, m2Pi()-0.01);
         %pitchAdj *= 0.5;
      }
      $mvPitch += %pitchAdj;
   }
}

And then I added the following in the public portion of the GameTSCtrl class:

virtual void onRightMouseUp(const GuiEvent &evt);

And then I put in the following as a function definition:

void GameTSCtrl::onRightMouseUp(const GuiEvent &evt)
{
   Parent::onRightMouseUp(evt);
   //I prefer to do it this way, don't ask me why... The other way is just fine though :P
   Con::executef(this, "onRightMouseUp", Con::getIntArg(evt.mouseClickCount));
}

I'm assuming a similarly exposed onRightMouseDown here, but if you hold the right mouse button down and move, you can look around, and it should let you get back to things (with a bug!) once you release.

So what's the bug? Well... I think it has to do with the Pitch and Yaw functions, but what I'm noticing is that if you right-click and drag around, when you let go, the mouse position is offset from it's actual position. At first, I thought it was just mucking with the object selection code I had, because I would need to click off to the sides or above/below the object I wanted to select, but then I noticed that as I moved the cursor about 100 pixels above some buttons, they were highlighting as if the cursor had entered the control. Now, I realize that the cursor probably is entering the control, but is being rendered in a significantly different position (not consistently off- I believe it has to do with whatever movements you make during that mouse dragging).

However, if that problem is solved, then you get a solution to being able to use the mouselook via right-click and drag... I'm still working on it myself, so if I stumble across it I'll post here. Though if anyone else wants to test it out and investigate, I'm not complaining ;)

#15 How can i Rotate the Camera with the Left Mouse Button? Any Forum ?Shall I have to integrate with the Engine?

#16 A year to late; but I solved this with a flag in Canvas.

Make sure your playGui.gui got the noCursor flag set to "0"
Then add

Canvas.setFieldValue("alwaysHandleMouseButtons", 1);

somewhere in a client startup script and the MouseUp function will trigger. Then to make the cursor hide/show add this functions in playGui.cs

function PlayGui::onMouseDown(%this, %pos, %start, %ray)
{
	hideCursor();
}
function PlayGui::onMouseUp(%this, %pos, %start, %ray)
{
	showCursor();
}

or onRightMouseDown/Up for using right mouse button.