[Beta 4 RESOLVED] Datablock Editor Treeview not displaying correctly

#1 I don't see it jumping as you describe it.

Clearly the reason they are there is for organization, so if you know you are looking for an SFXProfile but don't remember the first letter you only have to scan through all SFXProfiles not every datablock in the system.

This is a standard treeView control - some elements are branches and some elements are leafs. Actually I bet this is just a result of the horrible skin... the treeview skin used in the Object Editor has very clear folder icons that could be used for the datablock categories/classes.

*Disclaimer to MattF*
I know this was a very last minute addition to beta4 - and it kicks ass.

#2 No "jumping" here either. Don't really see how it could be more clearly delineated or organized -- except for some sort of skin as James mentioned, maybe some sort of unique icon for each 'class'.

#3 Hmm, let me look into this more. I see what you are suggesting it should look like and it makes sense, but it actually displays visually for me as like a listbox as opposed to a tree view, thus the confusion.

This is what it looks like for me:
Here

That matches the screen shots on the blog. Are you seeing something different? - I would expect that the lines for child nodes would obviously stand out as child nodes.

Moving this out of the bug list pending your response.

#4 Ok, I've figured it out.

It appears the problem is with the code in the DatablockEditor itself.

After replacing the DataBlockEditorPlugin::addExistingItem() method with the following, I get much better results. The old code used "%id" where I now have "%classId", which retains the parent value and now renders correctly.

function DatablockEditorPlugin::addExistingItem(%this, %datablock)
{
   %class = %datablock.getClassName();
   %classId = DatablockEditorTree.findItemByName(%class);
        
   if(%classId == 0)
      %classId = DatablockEditorTree.insertItem(0, %class);
         
   %name = %datablock.getName();
         
   if(%name $= "")
      %name = "unnamed";
   
   // it doesn't exist so lets add it
   if(%id == 0)
   {
      if(%this.PM.isDirty(%datablock))
         %name = %name @ " *";
         
      %id = DatablockEditorTree.insertItem(%classId, %name, %datablock);
   }
         
   return %id;   
}

#5 I, and I guess James too, was using a build from the repo. I suppose this is one of those cases where I should have had Beta4 installed before speaking up.

But I think it's safe to say that someone has already made changes in how the datablock editor looks/behaves.

This is what it looks like now (fresh from trunk):

#6 Ahh, much better. Probably the same fix I applied, thanks.