[Beta 2 Bug] Fullscreen Toggle Freezes Web Plugin

#1 Logged as TQA-179

#2 Greetings!

An oldie, but still a valid issue. Essentially, full screen should not be an option under web deployment. I believe by 1.1 Beta 3 that full screen was disallowed, but there was still an issue with the Options dialog doing some weird things that would cause your Torque window on the web page to shrink. Here are the fixes that are now in 1.1 Final (use 1.1 Beta 3 as your base):

In core/scripts/gui/optionsDlg.cs, in OptionsDlg::onWake(%this) change this:

%this-->OptGraphicsFullscreenToggle.setStateOn( Canvas.isFullScreen() );

to this:

if ( isFunction("getWebDeployment") && getWebDeployment() )
   {
      // Cannot enable full screen under web deployment
      %this-->OptGraphicsFullscreenToggle.setStateOn( false );
      %this-->OptGraphicsFullscreenToggle.setVisible( false );
   }
   else
   {
      %this-->OptGraphicsFullscreenToggle.setStateOn( Canvas.isFullScreen() );
   }

Next in OptionsDlg::applyGraphics( %this, %testNeedApply ) change this line directly under the // Gather the new video mode comment:

%newRes        = getWords( Canvas.getMode( %this-->OptGraphicsResolutionMenu.getSelected() ), $WORD::RES_X, $WORD::RES_Y );

to this:

if ( isFunction("getWebDeployment") && getWebDeployment() )
   {
      // Under web deployment, we use the custom resolution rather than a Canvas
      // defined one.
      %newRes = %this-->OptGraphicsResolutionMenu.getText();
   }
   else
   {
	   %newRes = getWords( Canvas.getMode( %this-->OptGraphicsResolutionMenu.getSelected() ), $WORD::RES_X, $WORD::RES_Y ); 
   }

A few lines under that, we have this:

// If we're in windowed mode switch the fullscreen check
   // if the resolution is bigger than the desktop.
	if ( %newFullScreen $= "false" )
	{
      %deskRes    = getDesktopResolution();      
      %deskResX   = getWord(%deskRes, $WORD::RES_X);
      %deskResY   = getWord(%deskRes, $WORD::RES_Y);
      if (  getWord( %newRes, $WORD::RES_X ) > %deskResX || 
            getWord( %newRes, $WORD::RES_Y ) > %deskResY )
      {
         %newFullScreen = "true";
         %this-->OptGraphicsFullscreenToggle.setStateOn( true );
      }
   }

Change it to read as:

// Under web deployment we can't be full screen.
   if ( isFunction("getWebDeployment") && getWebDeployment() )
   {
      %newFullScreen = false;
   }
   else if ( %newFullScreen $= "false" )
	{
      // If we're in windowed mode switch the fullscreen check
      // if the resolution is bigger than the desktop.
      %deskRes    = getDesktopResolution();      
      %deskResX   = getWord(%deskRes, $WORD::RES_X);
      %deskResY   = getWord(%deskRes, $WORD::RES_Y);
      if (  getWord( %newRes, $WORD::RES_X ) > %deskResX || 
            getWord( %newRes, $WORD::RES_Y ) > %deskResY )
      {
         %newFullScreen = "true";
         %this-->OptGraphicsFullscreenToggle.setStateOn( true );
      }
   }

That should be it.

- Dave

#3 I rather disagree that Fullscreen should not be allowed under web deployment providing that it works. To use Legions as an example, I just couldn't play that game effectively in the web page. I always jumped to fullscreen once I match started.

There are a variety of reasons to embed your client in a web page even if the players end up treating it like a regular app by always using it fullscreen. Primary for me is community integration, which I could instead do by adding webkit. Each has its own strengths.

#4 Hey Jason.

The changes above just make sure that the Options dialog matches what the source code is doing. The source doesn't allow full screen, and attempting to otherwise do so (from script) caused Torque's display to mess up.

Now having said that, allowing full screen with a web deployed game sounds like a good idea if the game and web page are designed for it. I'm not sure why the full screen mode was removed for a web deployed T3D game. A strong possibility is across-the-board browser compatibility and testing for it, but that's just a guess on my part.

- Dave

#5 I didn't have problems with FS in plugin mode (after removing the getWebDeployment limiters), but to avoid problems with the OS misreporting invalid resolutions, I limited it to using whatever resolution the desktop is using and not trying to switch.