Splash class - current status?

#1 Seems to be working fine for me.

#2 Alex, how are you testing that?

#3 I opened up Stronghold and ran through the waterblock. The various particle effects when doing so are generated by the Splash class, and there were indeed particle effects.

#4 Ah, that's what I thought. I've had a look at the code for the player class, and while there is a Splash object used in there, it looks to me like the splashing effects that you see are actually coming from regular particle emitters. I'm pretty sure the actual Splash objects are not producing any visible effects. The Splash class is also used by the Projectile class, and I am definitely not seeing any effect there. The crossbow in Stronghold has a splash datablock defined, so you should see a splash when a crossbow bolt enters the water.

#5 The splash class only manages particle emitters. It doesn't generate anything of its own (well, beyond the emitters I mean).

#6 OK, in that case, do you know what is required to make the projectile splashes work?

#7 They should just work... I'll look into it.

#8 Yeah, player splashes work no problem, it's the projectile splashes (SplashData) that doesn't work. Interesting thread about the removal of SplashData here: SplashData gone?, it seems that no one was using it according to Brian Ramage so he removed it from TSE/TGEa - 4 years ago! The kicker is that projectile splashes didn't work completely in TGE 1.5.2, though it was a simple fix.

#9 Ya, I was actually just digging into that. Fun fact: Tony is 100% correct when he said that the particle effects are coming from regular emitters. Player essentially reimplements the entire Splash class in itself, which is the effect you actually see. Go Player, you crazy crazy class.

So, I'm not sure when Splashes last worked.

Edit: Oh, and the code to render the rings was removed in TGEA. So, ya, Splashes don't work at all in 1.8. Good catch Tony!

#10 I just tried the fix that Michael linked to, and it actually worked! No rings of course, but better than nothing. Thanks guys.