I can not beleve this so easy bug exist so many years
by Henrysan · in Torque Game Engine Advanced · 06/08/2008 (3:50 am) · 9 replies
File: shapeBase.cpp
line: 206. // tgea1.7
func: shapeBaseData::preload
describe: on local connection, ShapeBaseData::collisionDetails,collisionBounds...will add more time.
fix: behind the comment line "// Resolve details and camera node indexes." to add one line
I can not believe this so easy bug exist so many years, both for tge and tgea.
Why nobody see it, or may forget to fix it. We need code more and more better!
I'm afraid GG's code quality, fix efficiency! May open CVS for buyer or some other way?
I do not have more time to check other dataBlock code, please someone check it.(now more important work
I need to do.)
Also I submit:
www.garagegames.com/mg/forums/result.thread.php?qt=75439
and more fix, clean up..., may some days later.
line: 206. // tgea1.7
func: shapeBaseData::preload
describe: on local connection, ShapeBaseData::collisionDetails,collisionBounds...will add more time.
fix: behind the comment line "// Resolve details and camera node indexes." to add one line
if (server || !GameConnection::getConnectionToServer()->isLocalConnection())
I can not believe this so easy bug exist so many years, both for tge and tgea.
Why nobody see it, or may forget to fix it. We need code more and more better!
I'm afraid GG's code quality, fix efficiency! May open CVS for buyer or some other way?
I do not have more time to check other dataBlock code, please someone check it.(now more important work
I need to do.)
Also I submit:
www.garagegames.com/mg/forums/result.thread.php?qt=75439
and more fix, clean up..., may some days later.
About the author
#2
06/08/2008 (12:49 pm)
Yeah I gotta be honest, I don't understand what bug you are trying to say exists.
#3
06/08/2008 (5:58 pm)
Likewise.
#4
06/08/2008 (7:39 pm)
He's saying if you have a local connection, this will give you a speed increase. Keep 'em coming, Henrysan.
#5
06/08/2008 (8:11 pm)
Well that is interesting.
#6
06/08/2008 (9:05 pm)
I'd need to check the codebase for context, but I'm not sure if it is a bug or a wicked sweet optimization. Regardless, I like seeing these!
#7
06/09/2008 (1:17 pm)
No offense but it seems like English might not have been his first language:) Thanks for the Bug Fix!
#8
06/09/2008 (1:29 pm)
Looks like a good optimization. However, I would like to point out that bug reports that take on a "chastising" (or "finger wagging") tone don't really accomplish much.
#9
English is not my first language.
In local connection, if you want done something with "collisionDetails" or "collisionBounds"...,you will easy find this error, more time for same collisionDetails & collisionBounds.
06/13/2008 (6:59 am)
Ha~,:)English is not my first language.
In local connection, if you want done something with "collisionDetails" or "collisionBounds"...,you will easy find this error, more time for same collisionDetails & collisionBounds.
Torque Owner Stefan Lundmark