Bug in ShapeBase

Hi All,

I believe there is a small bug in the ShapeBase class.

Specifically, the functions registerLights(), getRenderImageTransform(), and getImageTransform() all use the mountPoint data member in ShapeBaseImageData. However, in ShapeBaseImageData::preLoad() the mountPoint data member is never initialized with the node ID named "mountPoint" as it shold be. Therefore, the mountPoint data member is always 0.

The fix is to change the following in ShapeBaseImageData::preLoad() from:

// Resolve nodes & build mount transform
      ejectNode = shape->findNode("ejectPoint");
      muzzleNode = shape->findNode("muzzlePoint");
      retractNode = shape->findNode("retractionPoint");
      mountTransform = mountOffset;
      [b]S32 node[/b] = shape->findNode("mountPoint");
      if ([b]node[/b] != -1) {
         MatrixF total(1);
         do {
            MatrixF nmat;
            QuatF q;
            TSTransform::setMatrix(shape->defaultRotations[[b]node[/b]].getQuatF(&q),shape->defaultTranslations[[b]node[/b]],&nmat);
            total.mul(nmat);
            [b]node[/b] = shape->nodes[[b]node[/b]].parentIndex;
         }
         while([b]node[/b] != -1);

to

// Resolve nodes & build mount transform
      ejectNode = shape->findNode("ejectPoint");
      muzzleNode = shape->findNode("muzzlePoint");
      retractNode = shape->findNode("retractionPoint");
      mountTransform = mountOffset;
      [b]mountPoint[/b] = shape->findNode("mountPoint");
      if ([b]mountPoint[/b] != -1) {
         MatrixF total(1);
         do {
            MatrixF nmat;
            QuatF q;
            TSTransform::setMatrix(shape->defaultRotations[[b]mountPoint[/b]].getQuatF(&q),shape->defaultTranslations[[b]mountPoint[/b]],&nmat);
            total.mul(nmat);
            [b]mountPoint[/b] = shape->nodes[[b]mountPoint[/b]].parentIndex;
         }
         while([b]mountPoint[/b] != -1);

That will fix the problem. However, I also suggest that you remove mountPoint from the initPersistFields() call in ShapeBaseImageData because it should not be set via script. I also suggest that we change the variable name to mountNode so that it acts and is named the same as ejectNode, muzzleNode, and retractNode.

If you believe this is in error, please let me know!

edit: And mountPoint should be changed from a U32 to an S32.

Thanks
Todd