NextToken uses wrong stack

On working on the Enhanced TelnetDebugger i ran into this bug.

NextToken takes a string as the second parameter which will get the returned token on it. To return that value NextToken does this:

// set local variable if inside a function
      if (gEvalState.stack.size())
         Con::setLocalVariable(token,tmp);
      else
         Con::setVariable(token,tmp);

This works fine for main.cs where the evalstate stack is empty, but it doesn't in this case:

// main.cs
nextToken("first;second", token, ";");
echo( $token );

function setup()
{
   exec( "starter.fps/other.cs" );
   echo( %token2 ); // should be blank!
}
setup();

// starter.fps/other.cs
nextToken("first;second", token2, ";");

echo( $token2 ); // blank!

So when other.cs is executed from within setup() the eval stack is no longer empty. nextToken sees this and instead of making token2 a global it makes it a local on the setup() function stack.

(Side node... another bug/feature is that script exec'd from a function could in theory modify locals within in that function.)

Unless my logic is flawed this is a bug in NextToken. Please let me know if anyone thinks this isn't a bug... it effects my work on the debugger enhancements.

With the TelnetDebugger enhancements above i've sort of fixed this by...

1. exec'd code gets a stack frame with a null scopeName.
2. changed NextToken to do this...

// set local variable if inside a function
      if (gEvalState.stack.size() && 
         gEvalState.stack.last()->scopeName)
         Con::setLocalVariable(token,tmp);
      else
         Con::setVariable(token,tmp);

I should post my updated resource soon.