NoRenderBans bug

#1 I didn't read (the search didn't turn it up)... this bug was reported a few weeks ago too www.garagegames.com/mg/forums/result.thread.php?qt=23560.

#2 The bug is in Sky::calcTexCoords(). The TSE code looks like this:

void Sky::calcTexCoords( Point2F* texCoords, Point3F* renderPoints, S32 index, F32 lowerBanHeight )
{
   // Initialize the co-ords
   for(S32 i = 0; i < 4; ++i)
      texCoords[i].set(mTexCoord[i].x, mTexCoord[i].y);

   // Update the co-rds for the lower points on the face - have to make sure
   // texture stays the same while geometry changes.

   // BJGHACK - scaled by two, looks more convincing...
   texCoords[2].y = texCoords[3].y = 0.5f - mFabs(renderPoints[3].z / (2*mPoints[3].z));
}

The older TGE code looks like this:

void Sky::calcTexCoords(Point2F* texCoords, Point3F* renderPoints, S32 index)
{
   for(S32 x = 0; x < 4; ++x)
      texCoords[x].set(mTexCoord[x].x, mTexCoord[x].y);
   S32 length = (S32)(mFabs(mPoints[index].z) + mFabs(mPoints[index + 5].z));
   F32 per = mPoints[index].z - renderPoints[3].z;   
    
   texCoords[3].y = texCoords[2].y = (per / length);
}

The TGE code works... the TSE code does not. I'm not even exactly sure what the point of adding 'lowerBanHeight' to the function arguments or the reason for changing how the lower texture coords are calculated are. It seems like an unessasary change.

#3 I think it was mostly me porting the skybox code over in a bumbling manner. Not being clear on what was going on I ripped stuff apart. :)

Thanks for finding this fix, Tom. On my todo list (if Brian doesn't beat me to it).

#4 I'm 3000 miles away from fixing it right now ;) If you could get this one that would kick ass Ben.

#5 I'm 120 miles away, but only till Monday. We can race across the country to see who gets it into CVS. ;)

#6 Lol, race! race!

#7 OK, checked in. I win, I guess ;)