Way to Submit Source Code Bug Fixes?
by Charlie Patterson · in Torque Game Builder · 02/06/2012 (10:37 am) · 11 replies
I'm just curious if GarageGames has a way to submit T2D bug fixes? I haven't noticed one.
I've got 3 or 4 fixes for TorqueScript that are relatively simple but that go a long way. One even stops occasional crashes from within TorqueScript. They all deal with behaviors at some level, and all of them probably speed things up a bit in the process.
For instance:
* you can't successfully call a method on both behaviors and the owner script. (stack bungling)
* scheduling on an owner sends bungled schedules to each behavior.
* etc.
I've got 3 or 4 fixes for TorqueScript that are relatively simple but that go a long way. One even stops occasional crashes from within TorqueScript. They all deal with behaviors at some level, and all of them probably speed things up a bit in the process.
For instance:
* you can't successfully call a method on both behaviors and the owner script. (stack bungling)
* scheduling on an owner sends bungled schedules to each behavior.
* etc.
#2
I was hoping for an "official" way to get bug fixes from the community and into the next release. Is this what you meant also?
02/06/2012 (1:45 pm)
Thanks @Scott,I was hoping for an "official" way to get bug fixes from the community and into the next release. Is this what you meant also?
#3
02/06/2012 (7:17 pm)
You can send it to me (davidb@garagegames.com) or Chris Tauscher (chris@garagegames.com) and we will pass it along to the team. There is no guarantee that it will make it into a release, however, since it needs to undergo QA and work with any new functionality.
#4
What I will do is create an email, one for each patch, with the patch (usually 20 lines of code or less) and a summary of what is being fixed.
Thanks!
At this point, it may be worth putting on the forums as well. My concern is that I don't want to get my version changed up too much beyond the official releases, and I also don't want to lead others down that path. It's a real pain.
02/06/2012 (8:53 pm)
Great! Thanks! I think this is noteworthy and should be a sticky post. :)What I will do is create an email, one for each patch, with the patch (usually 20 lines of code or less) and a summary of what is being fixed.
Thanks!
At this point, it may be worth putting on the forums as well. My concern is that I don't want to get my version changed up too much beyond the official releases, and I also don't want to lead others down that path. It's a real pain.
#5
02/07/2012 (1:55 am)
Don't just sit on them - let people see the fixes and comment on them :)
#6
02/07/2012 (9:48 pm)
Heh. OK, @Ronny. It does take a bit of work to prep them for consumption, and considering that they are mostly to do with behaviors, and considering that my poll on who uses behaviors is turning out empty... I'm not sure how much effort to put in.
#7
I've done a bit of studying (never needed "patches" before) and it looks like a unified diff is the way to go. But as a wrench in the works, I have put TGB 1.7.5 in Subversion so I could keep track of my changes. Subversion allows me to make a patch with extreme ease, BUT you supposedly need access to the same repo to apply these patches. Thing is I don't see why, as long as I always patch "from the original 1.7.5 forward."
So I'm hoping someone can take the patch and give it a try. Here's the first www.garagegames.com/community/forums/viewthread/129695
02/08/2012 (12:45 pm)
Cool! Got a growing list of people using behaviors now, so I'm wondering if anyone can take a source-code (C++) patch and tell me if it works for them?I've done a bit of studying (never needed "patches" before) and it looks like a unified diff is the way to go. But as a wrench in the works, I have put TGB 1.7.5 in Subversion so I could keep track of my changes. Subversion allows me to make a patch with extreme ease, BUT you supposedly need access to the same repo to apply these patches. Thing is I don't see why, as long as I always patch "from the original 1.7.5 forward."
So I'm hoping someone can take the patch and give it a try. Here's the first www.garagegames.com/community/forums/viewthread/129695
#8
02/08/2012 (9:05 pm)
"svn export" is the command you want to export a clean source tree from Subversion.
#9
02/09/2012 (9:21 am)
@Ronny, I wouldn't want to release parts of the tree would I? I think it's against GG policy. Did you have something else in mind?
#10
02/09/2012 (10:02 am)
If you're generating patches from a version controlled directory you might also accidentally get .svn directories in the mix, depending on the tool used. Then "diff -Run" on it and a pristine TGB source tree to get a nice unified diff.
#11
02/09/2012 (10:35 am)
Thanks @Ronny, I'll keep that in mind. So far so good with using subversion's "create patch" feature. I made a pristine TGB 1.7.5 working copy, then I "merge" changes into it that I want to make a patch of, then I "create patch". I hope it's working. Waiting for more feedback...
Associate Scott Burns
GG Alumni