checking a players inventory for a weapon and equiping it

#1 I don't think you need "" around the weapon name. Also % missing from first use of client. Also (for reasons I don't know) I've never liked >0 and prefer !=0 or >=1

Check your console for errors.

And off the top of my head ...

//key for below snippet: %obj is the object - %client.player is the player

%datatype = %obj.getdatablock().getname();
//to get the object's name

if(%datatype $= "crossbow" && %client.player.getinventory(crossbow) < 1)
//check if the player has one or not
   %client.player.setinventory(crossbow, 1);
//if not, give it to the player's inventory so they can use it

#2 good eye the % is there it just didn't make it over on the copy and paste, the only problem is that the weapon its self is not passed just an enum value that tells us which weapon to equip (1 for xbow, 2 for bow, ect.

if it helps the item is defined as such
datablock ItemData(Crossbow)
{

category = "Weapon";

className = "Weapon";

shapeFile = "~/data/models/weapons/crossbow.dts";
mass = 1;
elasticity = 0.2;
friction = 0.6;
emap = true;
pickUpName = "a crossbow";
image = CrossbowImage;
};

#3 If you want to check for something in the inventory, then you're going to have to use the weapon's name at some point because that's what it's stored in the inventory as - even if it's just to include the enum in the itemdata to reference against.

Also, give a getName/getID echo for %client.getControlObject() and check that it's returning something - preferably the player object.

#4 %client.getControlObject works fine, and it mounts the weapon successfully it is just the if statement before hand that actually checks to see if the weapon is in the inventory that seems to be the problem.

The weaponEum is not actually used at the moment, I apologize if this added to the confusion, it is merely designed as structure for latter when multiple weapons are added.

I was thinking I maybe putting to much thought into this I could just create a new crossbow object locally IE

if (%client.player.getinventory(crossbow) != 0)
{
%temp = new item(){
datablock = "Crossbow";
};
%client.getControlObject().use(%temp);
}


still this feels like a bit of a hack though a little of tweaking in other areas could compensate, I will test things out and post code latter if it all works

#5 ok you were correct with the "" being the problem, i used them because that was the code example in another persons code example, just one last thing to figure out before I post full code

#6 hmnn the last thing I appear to be having trouble with is getting the weapon to set to something usable like

%x = crossbow;

#7 ... hey that actually works :P

here is what you do

function ServerCmduse(%client, %clientId)
{
echo("entering use function");
if (%client.player.getinventory(Crossbow) != 0)
{
%temp = Crossbow;
echo ("attempting to set weapon");
echo (%temp.getName() @ %temp.getID());
%client.getControlObject().use(%temp);
}
}

#8 ... yawwwn ... beddy-byes in a sec ... try it as a "string" like I used %datatype above:

%x $="crossbow";
//it's a word not numbers - then you need the "" cos it ain't in brackets