Game Development Community

[1.1B Bug] Player.cpp - swimming

by elvince · in Torque 3D Professional · 02/16/2010 (2:14 pm) · 3 replies

else if (mSwimming)
   {
...}

      if ( true )
      {
         // get the head pitch and add it to the moveVec
         // This more accurate swim vector calc comes from Matt Fairfax
         MatrixF xRot, zRot;

I Think the if (true) is a mistake in your implementation. I don't know what you want to put in...

#1
02/16/2010 (3:51 pm)
More than likely the person who wrote that was thinking of putting in an if-else block and then decided against it and rather then removing the brackets just put if(true) so it always ran that block of code. Or even more likely they were planning on having the more accurate swim vector calculation done only under certain situations which currently aren't implemented. It's not necessarily a mistake in the code and may end up being used for something in 1.1 final.
#2
02/17/2010 (3:32 am)
Agree Bryan, but we are in Beta and all functionalities should be implemented. Beta should be for bug fixing.
This is why I raise this point, because it's seems that the work around this function is not complete. So they can finish their job, sometimes you forget such things when you have a lot to do.
As per what I saw, there were a lot of changes.
#3
02/17/2010 (6:55 pm)
Removed the conditional surrounding that block of code. It was there to easily enabling / disabling that calculation for testing of its effects.