[1.1 Beta Bug] Some Materials with Specular Render Wrong - LOGGED

#1 @Ryan

Any shader errros in the console log when that happens?

#2 Hey Tom,

No shader errors in the log. I did notice however, that only the Building02Walls material is having this problem. Looking at the differences between this material and the other materials in the level, the Building02Walls has a Detail Normal Map in the Advanced Texture Maps that the others do not. Here's what I'm seeing:

1. If I remove the Detail Normal Map, the specular works fine with the regular Normal Map.

2. If I remove the regular Normal Map, the specular seems to work but is unaffected by the Detail Normal Map. Changing the Detail Normal Map strength or the Detail Map tiling does not affect the specular highlight.

So to summarize, "Normal Map + Detail Normal Map + Specular" leads to the image above. Removing either or both normal maps causes specular to work, but the Detail Normal Map does not seem to affect the final image.

#3 Let me preface this by stating that I'm not very experienced in DiretX programming or shaders, so this area of the engine is not my forte. :) In any event, I noticed something interesting. I used PIX to look at a frame like the bottom one above. Before drawing the building02walls material (w/ specular on), six IDirect3DDevice::SetTexture() calls are made to set:

1) diffuse map
2) detail map
3) bump map
4) detail bump map
5) lightInfobuffer
6) fizz map

But when I looked at the procedural pixel shader that was set for this draw, it only has five sampler2D inputs with no detail bump map:

Fragout main( ConnectData IN,
              uniform sampler2D diffuseMap      : register(S0),
              uniform sampler2D detailMap       : register(S1),
              uniform sampler2D bumpMap         : register(S2),
              uniform float4    rtParams4       : register(C3),
              uniform sampler2D lightInfoBuffer : register(S3),
              uniform float4    specularColor   : register(C0),
              uniform float     specularPower   : register(C1),
              uniform float     visibility      : register(C2),
              uniform sampler2D fizzMap         : register(S4),
              uniform float2    fizzScale       : register(C4)
)

If I run PIX again, turn off the specular (now it renders correctly), and grab a frame, I see four textures set (the two bump maps are not passed) and the procedural pixel shader has the corresponding four sampler2D inputs.

I don't know if this is causing the problem, but it definitely doesn't look right to me.

#4 I found and fixed this bug.

The issue is the 'rtParams4' in your snippit of the pixel shader above. That should actually be rtParams3... this is causing it to read the wrong shader constant causing problems.

The fix... in source\lighting\advanced\hlsl\advancedLightingFeaturesHLSL.cpp around line 363 in function DeferredBumpFeatHLSL::getResources:

Resources res; 
   if(!fd.features[MFT_SpecularMap])
   {
      res.numTex = 1;
      res.numTexReg = 1;

      if (  fd.features[MFT_PrePassConditioner] && // ADDED!
            fd.features.hasFeature( MFT_DetailNormalMap ) )
      {
         res.numTex += 1;
         if ( !fd.features.hasFeature( MFT_DetailMap ) )
            res.numTexReg += 1;
      }

Then a little further below in DeferredBumpFeatHLSL::setTexData line 394:

if (  !fd.features[MFT_Parallax] && !fd.features[MFT_SpecularMap] &&
         ( fd.features[MFT_PrePassConditioner] ||
           fd.features[MFT_PixSpecular] ) )
   {
      passData.mTexType[ texIndex ] = Material::Bump;
      passData.mTexSlot[ texIndex++ ].texObject = stageDat.getTex( MFT_NormalMap );

      if (  fd.features[MFT_PrePassConditioner] && // ADDED!
            fd.features.hasFeature( MFT_DetailNormalMap ) )
      {
         passData.mTexType[ texIndex ] = Material::DetailBump;
         passData.mTexSlot[ texIndex++ ].texObject = stageDat.getTex( MFT_DetailNormalMap );
      }

Let me know if it solves this issue for you.

#5 Works like a charm! Good job, Tom. The only thing I'm wondering about is if I remove the bump map, leaving the detail bump map there, the specular highlight is not affected by the detail bump map. In other words, the specular hightlight is smooth and unperturbed by the detail bump map alone. I'm assuming this is not the desired behavior... any thoughts?

Thanks for the fix. :)

#6

Quote:the specular highlight is not affected by the detail bump map.

Hum... anyone else seen this same behavior?

I'll have to look into that one... thanks for reporting it.

THREED-893

#7 Yep, I can see that.

1xNormal + 1xDetailNormal = both specular highlights
0xNormal but 1xDetailNormal = no specular at all

#8 Here's a pic to explain a little better.

#9 Ahhh.... i get what your saying now. If you have a detail normal map and no normal map.

The issue is that the detail normal map feature itself depends on their being a normal map. Fixing that is gonna be hard and really i don't see too many cases where you want just a detail normal map alone. If you really want that right now... use a dummy normal map with no features.

#10 Gotcha. I thought that might be the case. All's good then! :)