cartoon outlining (cartoon rendering part1)

Ok :)
I've been working on this for about a whole day, and still there are some bugs in it :(
But that doesn't hold me from posting it for others to use :)
so here is the code:
FOR SHAPES
in ts/tsMesh.cc
in TSMesh::render after:

S32 drawType = getDrawType(draw.matIndex>>30);

      glDrawElements(drawType,draw.numElements,GL_UNSIGNED_SHORT,&indices[draw.start]);
   }

add

/*cell shading*/
   bool doOutline=Con::getBoolVariable("$Pref::renderOutline",true);
   
   if (doOutline) {
      bool oldlighting=glIsEnabled(GL_LIGHTING);
      glDisable(GL_LIGHTING);
      F32 oldLineWidth;
      int oldcullface;
      glGetIntegerv(GL_CULL_FACE,&oldcullface);
      glGetFloatv(GL_LINE_WIDTH,&oldLineWidth);
      F32 lineWidth=Con::getFloatVariable("$Pref::OutlineWidth",2);
      glLineWidth(lineWidth);
      glCullFace(GL_FRONT);
      glPolygonMode (GL_BACK, GL_LINE);
      glDepthFunc(GL_LEQUAL);
      bool old2dtex=glIsEnabled(GL_TEXTURE_2D);
      glDisable(GL_TEXTURE_2D);
      F32 oldcolor[4];
      glGetFloatv(GL_CURRENT_COLOR,oldcolor);
      glColor4f(0.0f,0.0f,0.0f,1.0f);
      for (S32 i=0; i<primitives.size(); i++)
      {
         TSDrawPrimitive & draw = primitives[i];
         AssertFatal(draw.matIndex & TSDrawPrimitive::Indexed,
                  "TSMesh::render: rendering of non-indexed meshes no longer supported");

         S32 drawType = getDrawType(draw.matIndex>>30);
         glDrawElements(drawType,draw.numElements,GL_UNSIGNED_SHORT,&indices[draw.start]);
	  }
      glColor4fv(oldcolor);
      if (old2dtex) glEnable(GL_TEXTURE_2D);
      glDepthFunc(GL_LEQUAL);
      glLineWidth(oldLineWidth);
      glColor3f(1.0f,1.0f,1.0f);
      glCullFace(GL_BACK);
      glPolygonMode (GL_BACK, GL_FILL);
      if (oldlighting) glEnable(GL_LIGHTING);
   }
   /* end cell shading*/

FOR TERRAIN:
in terrain/terrRender.cc
in TerrainRender::renderXFCache after

U32 vertexCount = mXFIndexBuffer[count + 1];
      glDrawElements(mode, vertexCount, GL_UNSIGNED_SHORT, mXFIndexBuffer + count + 2);

add:

//Cell shading
   /*cell shading*/
   bool doOutline=Con::getBoolVariable("$Pref::renderOutline",true);
   if (doOutline) {
		/*extra cell shading*/
	   F32 oldLineWidth;
	   int oldcullface;
	   glGetIntegerv(GL_CULL_FACE,&oldcullface);
	   glGetFloatv(GL_LINE_WIDTH,&oldLineWidth);
	   F32 lineWidth=Con::getFloatVariable("$Pref::OutlineWidth",2);
	   glLineWidth(lineWidth);
	   //glBindTexture(GL_TEXTURE_2D,NULL);
	   glColor3f(0.0f,0.0f,0.0f);
	   glCullFace(GL_FRONT);
	   glPolygonMode (GL_BACK, GL_LINE);
			//Draw here
	   glColor3f(0.0f,0.0f,0.0f);
	   glDisable(GL_TEXTURE_2D);
	   glDrawElements(mode, vertexCount, GL_UNSIGNED_SHORT, mXFIndexBuffer + count + 2);
	   glEnable(GL_TEXTURE_2D);
	   glLineWidth(oldLineWidth);
	   glCullFace(GL_BACK);
	   glPolygonMode (GL_BACK, GL_FILL);
		/*end extra cs*/
   }
   /* end cell shading*/

FOR INTERIORS:
I'm still working on this one, and it's quite difficult (since there are lots of render codes in the interiors,
I've finally gotten some lines over it, but it is pretty glitchy, and will only look good on some interiors,
the $pref::renderOutline for interiors is $Pref::Interior::renderOutline,
and $pref::outlineWidth is $Pref::Interior::outlineWidth...
the reason i changed these vals for interiors is because i can imagine someone wanting terrain and shape, btu not this buggy interior code enabled :)
anyways, enough bullshit, code:
in interior/interiorRender.cc
in void Interior::render
after:

if (smRenderMode != 0) {
      PROFILE_START(IRO_DebugRender);
      debugRender(pMaterials, instanceHandle);
      PROFILE_END();
      return;
   }

add:

//cartoon outline
   bool doOutline=Con::getBoolVariable("$Pref::Interior::renderOutline",false);
   
   if (doOutline) {
	   F32 oldLineWidth=1;
	   glGetFloatv(GL_LINE_WIDTH,&oldLineWidth);
       F32 lineWidth=Con::getFloatVariable("$Pref::Interior::OutlineWidth",2);
       glLineWidth(lineWidth);
	   // Base textures
	   glBlendFunc(GL_ONE, GL_ZERO);
	   glDisable(GL_TEXTURE_2D);
	   glColor3f(0, 0, 0);
	   for (U32 i = 0; i < sgActivePolyListSize; i++) {
		  const Surface& rSurface = mSurfaces[sgActivePolyList[i]];
		   glBegin(GL_LINE_LOOP);
		   glVertex3fv(mPoints[mWindings[rSurface.windingStart]].point);

		   S32 skip = rSurface.windingStart + 1;
		   while (skip < (rSurface.windingStart + rSurface.windingCount)) {
			  glVertex3fv(mPoints[mWindings[skip]].point);
			  skip += 2;
		   }

		   skip -= 1;
		   while (skip > rSurface.windingStart) {
			  if (skip < (rSurface.windingStart + rSurface.windingCount))
				 glVertex3fv(mPoints[mWindings[skip]].point);
			  skip -= 2;
		   }
		   glEnd();
	   }
	   glEnable(GL_TEXTURE_2D);
	  //return;
   }
   //End cartoon outline

some prefs of this:
$Pref::renderOutline (true/false) render outlines or not
$Pref::outlineWidth (0-10) linewidth of outlines
You are free to use this code for whatever project you'd like, as long as you post every change you make on this forum so others can use it too :)

BUGS:
- enviroment mapped models have 'reflective' lines

Please if you like this stuff, contribute and help us with this!
also if you know anything about cell-shading, try to do that too...
in other words:
FRANK BIGNONE: please post your cell shading stuff from DOP here :(

and another word, noone is allowed to submit this as a resource except for me when i think the code is good enough to be posted as a resource :)