[bug] weapon -> trigger collision

#1 Previously reported in 1.01 linky

Possibly caused by the pushback code, only occurs when using eyeoffset (which utilizes said pushback code).

#2 @ Steve
The fixes you posted are already applied to the new build (1.1), cant seam to get it to work.

Could you post the line piece of code that i have to change?

#3 Yeah I know that link to links don't make any difference, just mentioning that it's been reported - though apparently no fix for this yet.

#4
Think the culprit is this:

if (getContainer()->castRay(start, end, 0xFFFFFFFF & ~(WaterObjectType|DefaultObjectType), &rinfo)) {
      if (rinfo.t < 1.0f)
         mWeaponBackFraction = 1.0f - rinfo.t;
      else
         mWeaponBackFraction = 0.0f;
   } else {
      mWeaponBackFraction = 0.0f;

It is including way too many object types in the collision mask. Try changing that to:

if (getContainer()->castRay(start, end, sCollisionMoveMask & ~(WaterObjectType|PhysicalZoneObjectType), &rinfo)) {

#5
Hehe... some general info about where this is would probably be helpful :)

It's Player::calcClassRenderData

#6
Yep, fixes it. Checked in for 1.1 Beta.

#7 And after I eventually managed to rebuild the correct solution ...

Yep, that seems to have cleared up that little problem, Rene.

#8 One further thing that occurred to me is that this function should really use castRayRendered, i.e. perform collision-detection against rendered geometry rather than collision geometry. Collision geometry is always just a rough approximation and simply not good enough for the weapon retraction which has the sole purpose of preventing *visible* object intersections.

Still, even with that change you get visible interpenetrations as the code does not take the actual volume of the weapon into account but rather just shoots a single straight ray. What it really needs to do is intersecting either the world box or (better yet) the collision geometry of the weapon with anything that is close to it and then push the weapon back far enough to get clear of any geometry that it would otherwise intersect with.

Finally, the retraction here is entirely a first-person rendering trick, i.e. we do not actually make the player shape lower its weapon which in fact we should do.

#9 Thanks Rene, It Works!

#10 Hey guys. I have a possibly related issue. I have a character that is throwing a grenade, and the grenade is bouncing back off of triggers. The grenade is a "new Item()". How can I stop it from physically colliding with triggers?

#11
Taking TriggerObjectType out of the server collision mask should do the trick:

const U32 sServerCollisionMask = (sClientCollisionMask |
                                  TriggerObjectType); // remove this

Actually not quite sure why this is in there since I *think* trigger collisions are handled differently. Have to check that.

#12 Perfect, thanks a lot!

#13 Logged as TQA-247.

#14 Confirmed as fixed for 1.1 Beta 2.